Moti Asayag has posted comments on this change. Change subject: engine: Code needs to run once, remove from loop ......................................................................
Patch Set 6: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/34130/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java: Line 51: supportedClusterVersionsSet != null && supportedClusterVersionsSet.isEmpty(); Line 52: if (!supportedClusterVersionsAvailable) { Line 53: log.warnFormat("Host {0} ({1}) doesn't contain Supported Cluster Versions, therefore 'defaultRoute'" Line 54: + " will not be sent via the SetupNetworks", host.getName(), host.getId()); Line 55: } please add a space line :) Line 56: boolean defaultRouteSupported = Line 57: supportedClusterVersionsAvailable Line 58: && FeatureSupported.defaultRoute(Collections.max(supportedClusterVersionsSet)); Line 59: -- To view, visit http://gerrit.ovirt.org/34130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8778a6e08dc696353af95bd2be67fdb31f7f2882 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
