Allon Mureinik has posted comments on this change. Change subject: core: Renamed the Method getStorageDomainIdForPoolByType ......................................................................
Patch Set 4: Code-Review+1 (3 comments) http://gerrit.ovirt.org/#/c/34030/4//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-08 09:56:25 +0300 Line 4: Commit: Idan Shaby <[email protected]> Line 5: CommitDate: 2014-10-20 14:37:35 +0300 Line 6: Line 7: core: Renamed the Method getStorageDomainIdForPoolByType The fact that you're talking about StorageDomainDAO's method should be mentioned somewhere here... Line 8: Line 9: The method's parameters types are clear enough, so there's no need to Line 10: include them also in the method's name. Line 11: Line 9: The method's parameters types are clear enough, so there's no need to Line 10: include them also in the method's name. Line 11: Line 12: Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Line 13: Bug-Url: https://bugzilla.redhat.com/1085398 > It does not contain any logic, but the solution for this bug uses it: So shouldn't this be "Related-To: http://..."; ? http://gerrit.ovirt.org/#/c/34030/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java: Line 22: public class StorageDomainDAODbFacadeImpl extends BaseDAODbFacade implements StorageDomainDAO { Line 23: Line 24: @Override Line 25: public Guid getMasterStorageDomainIdForPool(Guid pool) { Line 26: return getStorageDomainId(pool, StorageDomainType.Master); > You are right, but shouldn't it be in a different patch? You're touching the signature - it can be in the same patch. Line 27: } Line 28: Line 29: @Override Line 30: public StorageDomain getStorageDomain(Guid pool, StorageDomainType type) { -- To view, visit http://gerrit.ovirt.org/34030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
