Liran Zelkha has uploaded a new change for review.

Change subject: core: Improve performance of getdisksvmguid
......................................................................

core: Improve performance of getdisksvmguid

getdisksvmguid is using view all_disks_including_snapshots which used
UNION instead of UNION ALL. This caused a needless performance hit.
On the performance environment it reduced execution from 2.2s to 700ms.

Change-Id: If037bf4a20f7cae9dd6ab6e7f95bcf0681b3bda1
Bug-Url: https://bugzilla.redhat.com/1141543
Signed-off-by: [email protected] <[email protected]>
---
M packaging/dbscripts/create_views.sql
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/34341/1

diff --git a/packaging/dbscripts/create_views.sql 
b/packaging/dbscripts/create_views.sql
index cf2e250..f790349 100644
--- a/packaging/dbscripts/create_views.sql
+++ b/packaging/dbscripts/create_views.sql
@@ -221,7 +221,7 @@
            null AS device_size
     FROM images_storage_domain_view
     INNER JOIN storage_for_image_view ON images_storage_domain_view.image_guid 
= storage_for_image_view.image_id
-    UNION
+    UNION ALL
     SELECT 1 AS disk_storage_type,
            null AS storage_id, -- Storage domain fields
            null AS storage_path,


-- 
To view, visit http://gerrit.ovirt.org/34341
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If037bf4a20f7cae9dd6ab6e7f95bcf0681b3bda1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to