Allon Mureinik has posted comments on this change. Change subject: core: Improve performance of getdisksvmguid ......................................................................
Patch Set 1: Code-Review+2 Both queries select a constant as the storage type: 1st query: SELECT 0 AS disk_storage_type 2nd query: SELECT 1 AS disk_storage_type Hence, by definition UNION and UNION ALL will have exactly the same functionality. In other words, this patch is guaranteed to be safe. Approved. Liran - please verify? -- To view, visit http://gerrit.ovirt.org/34341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If037bf4a20f7cae9dd6ab6e7f95bcf0681b3bda1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
