Martin Peřina has posted comments on this change. Change subject: core: remove ovirt logger from vdsbroker and friends ......................................................................
Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/34374/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java: Line 58: // Retrieve storage domains by VG-IDs extracted from the LUNs Line 59: List<String> vgIDs = getVolumeGroupIdsByLUNs(filteredLUNs); Line 60: storageDomains = getStorageDomainsByVolumeGroupIds(vgIDs); Line 61: } catch (RuntimeException e) { Line 62: log.error("Failed to retrieve storage domains by connections info: {}", e.getMessage()); ? log.debug("Exception", ex); Line 63: getQueryReturnValue().setSucceeded(false); Line 64: return; Line 65: } Line 66: Line 211: try { Line 212: returnValue = executeGetVGInfo( Line 213: new GetVGInfoVDSCommandParameters(getParameters().getVdsId(), vgID)); Line 214: } catch (RuntimeException e) { Line 215: log.error("Could not get info for VG ID: '{}': {}", ? log.debug("Exception", ex); Line 216: vgID, e.getMessage()); Line 217: continue; Line 218: } Line 219: Line 245: try { Line 246: returnValue = executeHSMGetStorageDomainInfo( Line 247: new HSMGetStorageDomainInfoVDSCommandParameters(getParameters().getVdsId(), storageDomainId)); Line 248: } catch (RuntimeException e) { Line 249: log.error("Could not get info for storage domain ID: '{}': {}", ? log.debug("Exception", ex); Line 250: storageDomainId, e.getMessage()); Line 251: return null; Line 252: } Line 253: http://gerrit.ovirt.org/#/c/34374/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 658: } Line 659: } catch (IRSErrorException ex) { Line 660: logFailureMessage("Could not finish afterRefreshTreatment", ex); Line 661: if (log.isDebugEnabled()) { Line 662: log.error("Exception", ex); log.debug("Exception", ex); Line 663: } Line 664: } catch (RuntimeException ex) { Line 665: logFailureMessage("Could not finish afterRefreshTreatment", ex); Line 666: log.error("Exception", ex); Line 662: log.error("Exception", ex); Line 663: } Line 664: } catch (RuntimeException ex) { Line 665: logFailureMessage("Could not finish afterRefreshTreatment", ex); Line 666: log.error("Exception", ex); ? log.debug("Exception", ex); Line 667: } Line 668: } Line 669: Line 670: private void handleVdsMaintenanceTimeout() { -- To view, visit http://gerrit.ovirt.org/34374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae367e2c2fe3df862c8a345ca73575198f4c6edd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
