Oved Ourfali has posted comments on this change. Change subject: core: remove ovirt logger from vdsbroker and friends ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34374/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java: Line 82: returnValue.setExceptionString(vdcExc.getMessage()); Line 83: } Line 84: log.error("Query '{}' failed: {}", Line 85: getClass().getSimpleName(), Line 86: vdcExc.getMessage()); aren't you missing a "{}" here? Line 87: log.error("Exception", vdcExc); Line 88: } else { Line 89: returnValue.setExceptionString(ex.getMessage()); Line 90: log.error("Query '{}' failed: {}", -- To view, visit http://gerrit.ovirt.org/34374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae367e2c2fe3df862c8a345ca73575198f4c6edd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
