Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: ignoring case on DB and DB USER names
......................................................................
Patch Set 1:
The issue is that SQL dialects honor case on identifier only it they are quoted
but we are issuing
create database {database} owner {user} ...
in packaging/setup/ovirt_engine_setup/engine_common/database.py
and than
ALTER DATABASE \"${DBFUNC_DB_DATABASE}\" SET client_min_messages=ERROR;"
in packaging/dbscripts/dbfunc-common.sh
and so it fails cause we created it without the quote forcing a lower case and
than we reference it in the original case.
I didn't checked all the SQL statement.
Eli, as a general rule, should we honor the case on DB identifier or should we
ignore it?
--
To view, visit http://gerrit.ovirt.org/34444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I367e47889b2445d156f85301f6a87f5892bf9012
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
