Omer Frenkel has posted comments on this change. Change subject: core, restapi: Fix architecture checks in REST API ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25687/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 285: Line 286: if (getParameters().getArchitecture() != null Line 287: && getParameters().getArchitecture() != getVdsGroup().getArchitecture()) { Line 288: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_CLUSTER_DIFFERENT_ARCHITECTURES); Line 289: } you could extract this as a method in VmManagementCommandBase and reuse it also in addvm Line 290: Line 291: if (!VmHandler.isOsTypeSupported(vmFromParams.getOs(), Line 292: getVdsGroup().getArchitecture(), getReturnValue().getCanDoActionMessages())) { Line 293: return false; -- To view, visit http://gerrit.ovirt.org/25687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9122dab810ba8f1dd37a71b66a9344354718637a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
