Vitor de Lima has posted comments on this change. Change subject: core, restapi: Fix architecture checks in REST API ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25687/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java: Line 235: } Line 236: Line 237: protected boolean isArchitectureCompatibleWithCluster(List<String> reasons) { Line 238: if (getParameters().getArchitecture() != null Line 239: && getParameters().getArchitecture() != getVdsGroup().getArchitecture()) { > why do we need parameter for the arch? cant we get the vm arch from the sel We could, but this patch is a little bit sillier than that. This patch checks if the user put a wrong architecture in the incoming XML while using the REST API, so in order to pass the architecture into the backend a parameter is used. Line 240: reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_VM_CLUSTER_DIFFERENT_ARCHITECTURES.toString()); Line 241: return false; Line 242: } Line 243: -- To view, visit http://gerrit.ovirt.org/25687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9122dab810ba8f1dd37a71b66a9344354718637a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
