Martin Peřina has posted comments on this change.
Change subject: core: Replace oVirt logger with slf4j in bll
......................................................................
Patch Set 6:
Yair, since you merged logging refactoring patches from the beginning and we
used same approach from the beginning, I wonder why you raise this question on
the last patch?
Nevertheless I use these rules to quote:
1) I quote non number attribute values (we may discuss it for future, because
non null values are not needed to quote)
2) I don't quote primitive numbers
3) I don't quote error messages, because they are the last part of message
string after ':', so IMHO there's no need to quote
4) I don't quote strings which creates sentence of log message,for example
log.info("Feature was {}", enabled ? "enabled" : "disabled");
5) For the rest of cases I use common sense :)
--
To view, visit http://gerrit.ovirt.org/34359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82070b252197458422792c49b2135fcb9b9b1430
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
