Martin Peřina has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/34359/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java: Line 101: vmFromConfiguration.setDiskMap(getParameters().getDiskMap()); Line 102: vmFromConfiguration.setImages(getDiskImageListFromDiskMap(getParameters().getDiskMap())); Line 103: } Line 104: } catch (OvfReaderException e) { Line 105: log.error("Failed to parse a given ovf configuration: '{}':\n{}", > there is no need for ' in message Sorry, forgot to move them to data Line 106: e.getMessage(), Line 107: ovfEntityData.getOvfData()); Line 108: log.debug("Exception", e); Line 109: } http://gerrit.ovirt.org/#/c/34359/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java: Line 74: vmTemplateFromConfiguration.setDiskList(imageList); Line 75: ensureDomainMap(imageList, getParameters().getDestDomainId()); Line 76: } Line 77: } catch (OvfReaderException e) { Line 78: log.error("Failed to parse a given ovf configuration: '{}':\n{}", > there is no need for ' in message Sorry, forgot to move them to data Line 79: e.getMessage(), Line 80: ovfEntityData.getOvfData()); Line 81: log.debug("Exception", e); Line 82: } -- To view, visit http://gerrit.ovirt.org/34359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82070b252197458422792c49b2135fcb9b9b1430 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
