Moti Asayag has posted comments on this change.

Change subject: core: Add JPA infrastructure to oVirt
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/33832/13/backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml
File backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml:

Line 6:             <property name="javax.persistence.jdbc.user" 
value="${engine.db.username}" />
Line 7:             <property name="javax.persistence.jdbc.password" 
value="${engine.db.password}" />
Line 8:             <property name="javax.persistence.jdbc.url" 
value="${engine.db.url}" />
Line 9:             <property name="javax.persistence.validation.mode" 
value="NONE" />
Line 10:             <property name="hibernate.dialect" 
value="org.hibernate.dialect.HSQLDialect" />
> or org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect
the second doesn't implement org.hibernate.dialect.Dialec, hence cannot be in 
use. 

which leaves with the question for the postgres dialect.
Line 11:         </properties>
Line 12:     </persistence-unit>


-- 
To view, visit http://gerrit.ovirt.org/33832
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2440162230449d0c335a2c2d418fb9ff7e854793
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to