Liran Zelkha has posted comments on this change. Change subject: core: Add JPA infrastructure to oVirt ......................................................................
Patch Set 13: (4 comments) http://gerrit.ovirt.org/#/c/33832/13/backend/manager/modules/common/pom.xml File backend/manager/modules/common/pom.xml: Line 53: Line 54: <dependency> Line 55: <groupId>org.hibernate</groupId> Line 56: <artifactId>hibernate-entitymanager</artifactId> Line 57: <version>4.3.0.Final</version> > upstream jboss is 4.0.1 Done Line 58: </dependency> Line 59: Line 60: <dependency> Line 61: <groupId>javax.annotation</groupId> http://gerrit.ovirt.org/#/c/33832/13/backend/manager/modules/dal/pom.xml File backend/manager/modules/dal/pom.xml: Line 74: </dependency> Line 75: <dependency> Line 76: <groupId>org.hibernate</groupId> Line 77: <artifactId>hibernate-entitymanager</artifactId> Line 78: <version>4.0.1.Final</version> > why do you have version here? it should take it from parent, no? Done Line 79: </dependency> Line 80: </dependencies> Line 81: <build> Line 82: <filters> http://gerrit.ovirt.org/#/c/33832/13/backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml File backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml: Line 5: <property name="javax.persistence.jdbc.driver" value="${engine.db.driver}" /> Line 6: <property name="javax.persistence.jdbc.user" value="${engine.db.username}" /> Line 7: <property name="javax.persistence.jdbc.password" value="${engine.db.password}" /> Line 8: <property name="javax.persistence.jdbc.url" value="${engine.db.url}" /> Line 9: <property name="javax.persistence.validation.mode" value="NONE" /> > Since we're already having a usage of the Hibernate validation, wouldn't we Done Line 10: <property name="hibernate.dialect" value="org.hibernate.dialect.HSQLDialect" /> Line 11: </properties> Line 12: </persistence-unit> Line 6: <property name="javax.persistence.jdbc.user" value="${engine.db.username}" /> Line 7: <property name="javax.persistence.jdbc.password" value="${engine.db.password}" /> Line 8: <property name="javax.persistence.jdbc.url" value="${engine.db.url}" /> Line 9: <property name="javax.persistence.validation.mode" value="NONE" /> Line 10: <property name="hibernate.dialect" value="org.hibernate.dialect.HSQLDialect" /> > the second doesn't implement org.hibernate.dialect.Dialec, hence cannot be Done Line 11: </properties> Line 12: </persistence-unit> -- To view, visit http://gerrit.ovirt.org/33832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2440162230449d0c335a2c2d418fb9ff7e854793 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
