Sandro Bonazzola has posted comments on this change. Change subject: iscsi: add HE disk to the engine as direct lun ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34783/1/src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py File src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py: Line 65: def _closeup(self): Line 66: lun = ovirtsdk.xml.params.LogicalUnit( Line 67: id=self.environment[ohostedcons.StorageEnv.GUID], Line 68: address=self.environment[ohostedcons.StorageEnv.ISCSI_IP_ADDR], Line 69: port=self.environment[ohostedcons.StorageEnv.ISCSI_PORT], looks like this require a int(self.environment[ohostedcons.StorageEnv.ISCSI_PORT]) Line 70: target=self.environment[ohostedcons.StorageEnv.ISCSI_TARGET], Line 71: username=self.environment[ohostedcons.StorageEnv.ISCSI_USER], Line 72: password=self.environment[ohostedcons.StorageEnv.ISCSI_PASSWORD], Line 73: ) -- To view, visit http://gerrit.ovirt.org/34783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5640bde713fc4d09cf74a7037c62e833495934 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
