Sandro Bonazzola has posted comments on this change.

Change subject: iscsi: add HE disk to the engine as direct lun
......................................................................


Patch Set 1: Verified-1

I guess it's the port number.

 Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/otopi/context.py", line 142, in 
_executeMethod
    method['method']()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/engine/add_disk.py",
 line 103, in _closeup
    engine_api.disks.add(disk)
  File "/usr/lib/python2.6/site-packages/ovirtsdk/infrastructure/brokers.py", 
line 9781, in add
    body=ParseHelper.toXml(disk),
  File "/usr/lib/python2.6/site-packages/ovirtsdk/utils/parsehelper.py", line 
53, in toXml
    entity.export(output, 0, name_=entity_tag)
  File "/usr/lib/python2.6/site-packages/ovirtsdk/xml/params.py", line 23810, 
in export
    self.exportChildren(outfile, level + 1, namespace_, name_, 
pretty_print=pretty_print)
  File "/usr/lib/python2.6/site-packages/ovirtsdk/xml/params.py", line 23883, 
in exportChildren
    self.lun_storage.export(outfile, level, namespace_, name_='lun_storage', 
pretty_print=pretty_print)
  File "/usr/lib/python2.6/site-packages/ovirtsdk/xml/params.py", line 15587, 
in export
    self.exportChildren(outfile, level + 1, namespace_, name_, 
pretty_print=pretty_print)
  File "/usr/lib/python2.6/site-packages/ovirtsdk/xml/params.py", line 15625, 
in exportChildren
    logical_unit_.export(outfile, level, namespace_, name_='logical_unit', 
pretty_print=pretty_print)
  File "/usr/lib/python2.6/site-packages/ovirtsdk/xml/params.py", line 15154, 
in export
    self.exportChildren(outfile, level + 1, namespace_, name_, 
pretty_print=pretty_print)
  File "/usr/lib/python2.6/site-packages/ovirtsdk/xml/params.py", line 15170, 
in exportChildren
    outfile.write('<%sport>%s</%sport>%s' % (namespace_, 
self.gds_format_integer(self.port, input_name='port'), namespace_, eol_))
  File "/usr/lib/python2.6/site-packages/ovirtsdk/xml/params.py", line 108, in 
gds_format_integer
    return '%d' % input_data
 TypeError: %d format: a number is required, not str

-- 
To view, visit http://gerrit.ovirt.org/34783
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5640bde713fc4d09cf74a7037c62e833495934
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to