Alexander Wels has posted comments on this change. Change subject: frontend: Pass JSESSIONID in VV file ......................................................................
Patch Set 9: Code-Review+1 Okay, I did some more research and now I understand what you mean. Since most models are not managed by GIN (yet). You can't just inject what you need into those models. That is where the resolvers comes in. So for now, I have no issues with this code, but in the long run I will get all these models managed by GIN, and then we can get rid of the resolver and simply inject. +1 from UI perspective, if you need a +2 overal let me know. -- To view, visit http://gerrit.ovirt.org/33770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6d2c91b99240527760b57a6079b5f986aff5b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
