Alon Bar-Lev has posted comments on this change. Change subject: core: Store only single certificate ......................................................................
Patch Set 14: (9 comments) http://gerrit.ovirt.org/#/c/33717/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java: Line 23 Line 24 Line 25 Line 26 Line 27 this should be modified to password of provider store, and in previous patch most probably what you put in the ovirt-engine.conf.in was incorrect... Line 27 Line 28 Line 29 Line 30 Line 31 we do not need to create empty, this function should be removed in previous patch I guess. Line 35 Line 36 Line 37 Line 38 Line 39 so this function could have been used in previous patch instead of opening the store? or use the other one here? Line 38 Line 39 Line 40 Line 41 Line 42 same Line 39 Line 40 Line 41 Line 42 Line 43 get from config Line 51 Line 52 Line 53 Line 54 Line 55 same Line 59: } Line 60: Line 61: public static void setCertificateChain(List<? extends Certificate> chain) throws CertificateEncodingException, Line 62: KeyStoreException { Line 63: KeyStore ks = ExternalTrustStoreInitializer.getTrustStore(); not sure why you need class name loadTrustStore? Line 64: Certificate certificate = chain.get(chain.size() - 1); Line 65: String alias = Integer.toString(certificate.getEncoded().hashCode()); Line 66: ks.setCertificateEntry(alias, certificate); Line 67: setTrustStore(ks); Line 63: KeyStore ks = ExternalTrustStoreInitializer.getTrustStore(); Line 64: Certificate certificate = chain.get(chain.size() - 1); Line 65: String alias = Integer.toString(certificate.getEncoded().hashCode()); Line 66: ks.setCertificateEntry(alias, certificate); Line 67: setTrustStore(ks); saveTrustStore? Line 68: } http://gerrit.ovirt.org/#/c/33717/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateChainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateChainCommand.java: Line 56: Line 57: private void saveChainToTrustStore(List<? extends Certificate> chain) { Line 58: if (chain != null && chain.size() > 0) { Line 59: try { Line 60: ExternalTrustStoreInitializer.setCertificateChain(chain); addCertificateChain? Line 61: setSucceeded(true); Line 62: } catch (Throwable e) { Line 63: handleException(e); Line 64: } -- To view, visit http://gerrit.ovirt.org/33717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9bd8cd7f913cf23eca839452b6e113f749966f7 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
