Yair Zaslavsky has posted comments on this change.

Change subject: core: Store only single certificate
......................................................................


Patch Set 14:

(2 comments)

http://gerrit.ovirt.org/#/c/33717/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java:

Line 59:     }
Line 60: 
Line 61:     public static void setCertificateChain(List<? extends Certificate> 
chain) throws CertificateEncodingException,
Line 62:             KeyStoreException {
Line 63:         KeyStore ks = ExternalTrustStoreInitializer.getTrustStore();
> not sure why you need class name
please elaborate what you meant here.
Line 64:         Certificate certificate = chain.get(chain.size() - 1);
Line 65:         String alias = 
Integer.toString(certificate.getEncoded().hashCode());
Line 66:         ks.setCertificateEntry(alias, certificate);
Line 67:         setTrustStore(ks);


Line 63:         KeyStore ks = ExternalTrustStoreInitializer.getTrustStore();
Line 64:         Certificate certificate = chain.get(chain.size() - 1);
Line 65:         String alias = 
Integer.toString(certificate.getEncoded().hashCode());
Line 66:         ks.setCertificateEntry(alias, certificate);
Line 67:         setTrustStore(ks);
> saveTrustStore?
Done
Line 68:     }


-- 
To view, visit http://gerrit.ovirt.org/33717
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bd8cd7f913cf23eca839452b6e113f749966f7
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to