Michael Kublin has posted comments on this change.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
Line 182: default:
Wrong message, you are removing vm from DB
Line 239: // Get all disk images for VM (VM should not have any image
disk associated with it).
ImagesHandler.filterImageDisks(DbFacade.getInstance().getDiskDao().getAllForVm(getVmId()),
true,
false);
These is line from RemoveAllImagesCommand why they are different?
Line 258: */
Mark of image as Illegal should be set at RemoveImageCommand, I think.
Also why they are illegal at Dettach disk no special treatment for snapshots,
it is means that we failed to remove disk - will became floating. Or we have
bug at Dettach disk command
--
To view, visit http://gerrit.ovirt.org/5806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
