Allon Mureinik has posted comments on this change.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(2 inline comments)
looks reasonable, please see mkublin's comments and my question inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java
Line 62: if (vdcReturnValue.getSucceeded()) {
Just to be perfectly sure - does getSucceeded mean that the task was
successfully created or that the image was fully deleted?
Line 91: private void updateDiskImagesToIllegal(DiskImage diskImage) {
question: where are the VM's snapshot's removed?
--
To view, visit http://gerrit.ovirt.org/5806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
