Moti Asayag has posted comments on this change. Change subject: engine: Add ability for conditional steps execution ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35032/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2342: setExaminedSteps(step); Line 2343: } Line 2344: Line 2345: public Conditional skip(StepEnum... step) { Line 2346: setExaminedSteps(step); > i dont understand this, skip will override the set of examined steps set by skippedSteps will store the steps that should be skipped, after the condition examines the examinedSteps. so if you call skip(A, B).when(true).skip(D).when(true); the result is that skipTests will store A,B,D. Line 2347: return this; Line 2348: } Line 2349: Line 2350: public Conditional when(boolean condition) { -- To view, visit http://gerrit.ovirt.org/35032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05b0b971da7012cff701d5ab2efa28bedd90deca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
