Moti Asayag has posted comments on this change. Change subject: engine: Add ability for conditional steps execution ......................................................................
Patch Set 1: Omer's patch doesn't have the flexibility to skip certain part of the command from being executed, and it does by pass both verification and execution. If wishes to save lines of code and reduce complexity from the CommandBase, patch 34935 should be abandoned as well and we should stick to the specified on the second bullet on the commit message of 34935: have that logic encapsulated in the concrete command. -- To view, visit http://gerrit.ovirt.org/35032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05b0b971da7012cff701d5ab2efa28bedd90deca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
