Alon Bar-Lev has posted comments on this change. Change subject: core : Introduce engine_sessions table and DAO ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/35148/2/packaging/dbscripts/engine_sessions_sp.sql File packaging/dbscripts/engine_sessions_sp.sql: Line 4: Create or replace FUNCTION InsertEngineSession(v_id VARCHAR(255), Line 5: v_user_id UUID, Line 6: v_user_name VARCHAR(255), Line 7: v_group_ids VARCHAR(2048), Line 8: v_role_ids VARCHAR(255)) any reason to limit this to 255? Line 9: RETURNS VOID Line 10: AS $procedure$ Line 11: BEGIN Line 12: INSERT INTO engine_sessions(id, user_id, user_name, group_ids, role_ids) http://gerrit.ovirt.org/#/c/35148/2/packaging/dbscripts/upgrade/03_06_0530_add_engine_sessions.sql File packaging/dbscripts/upgrade/03_06_0530_add_engine_sessions.sql: Line 1: CREATE TABLE engine_sessions ( Line 2: id character varying(255) NOT NULL, not sure what is varying... can we hold here any utf8 string? won't it better to hold it as integer(sequence) and have another field of session id? will it make mla to work more efficient if we have sequence? Line 3: user_id uuid NOT NULL, Line 4: user_name character varying(255) NOT NULL, Line 5: group_ids text, Line 6: role_ids text, Line 2: id character varying(255) NOT NULL, Line 3: user_id uuid NOT NULL, Line 4: user_name character varying(255) NOT NULL, Line 5: group_ids text, Line 6: role_ids text, can above two be null? Line 7: CONSTRAINT pk_engine_sessions PRIMARY KEY(id) -- To view, visit http://gerrit.ovirt.org/35148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b4d9cfc3edc6084fc0436ecfd09c82d5ae57f5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
