Alon Bar-Lev has posted comments on this change. Change subject: core : Introduce engine_sessions table and DAO ......................................................................
Patch Set 3: (1 comment) nice! minor comment. http://gerrit.ovirt.org/#/c/35148/3/packaging/dbscripts/upgrade/03_06_0560_add_engine_sessions.sql File packaging/dbscripts/upgrade/03_06_0560_add_engine_sessions.sql: Line 1: CREATE SEQUENCE engine_session_seq INCREMENT BY 1 START WITH 1; Line 2: Line 3: CREATE TABLE engine_sessions ( Line 4: id bigint DEFAULT nextval('engine_session_seq'::regclass) NOT NULL, Line 5: engine_session_id character varying(255) NOT NULL, please at least 512 Line 6: user_id uuid NOT NULL, Line 7: user_name character varying(255) NOT NULL, Line 8: group_ids text, Line 9: role_ids text, -- To view, visit http://gerrit.ovirt.org/35148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b4d9cfc3edc6084fc0436ecfd09c82d5ae57f5e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
