Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Use existing Engine session for REST API integration ......................................................................
Patch Set 2: Code-Review+1 (1 comment) +1 for logic http://gerrit.ovirt.org/#/c/35185/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java: Line 114: builder.setHeader("Session-TTL", restApiSessionTimeout); //$NON-NLS-1$ Line 115: Line 116: // Express additional preferences for serving this request Line 117: String preferValue = "persistent-auth, csrf-protection"; //$NON-NLS-1$ Line 118: if (engineAuthToken != null) { I think you can ask this question once within this logic, set both header and prefer. Line 119: // Enforce expiry of existing session when acquiring new session Line 120: preferValue += ", new-auth"; //$NON-NLS-1$ Line 121: } Line 122: builder.setHeader("Prefer", preferValue); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/35185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3905b3b5834a0f7327321e93064274df0d1db65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
