Michael Kublin has posted comments on this change. Change subject: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCommand (#840838) ......................................................................
Patch Set 7: Do not submit (1 inline comment) The whole concept of sulution is wrong. I did bot success to connect host to storage why I will trigger a reconstruct?. We have at least 4-5 automatic processes that will trigger a reconstruct, why I need additional one? U triggering a reconstruct inside additional two global locks, I solve ta least one bug with deadlock, and solution was extract a reconstruct from that lock, your solution will cause with high probability to deadlock. Perfomance: today host can be stuck for 3 minutes with status Unassigned, triggering reconstruct inside of initVdsOnUp will cause to 6 minutes in worst case. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java Line 122: reloadStoragePool(); Why these? How these will help? -- To view, visit http://gerrit.ovirt.org/7061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec43f368370da88f81dbe211331649a16c53f053 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
