Michael Kublin has posted comments on this change. Change subject: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCommand (#840838) ......................................................................
Patch Set 8: "answeres to mkublin comments: in case that you have only one active host in the pool, why wouldn't you try to reconstruct in order to make it useable? that's the scenario that this solution is meant to solve. if you don't reconstruct, the pool won't be connected to the host and it won't be spm." - Now, getAllRunningVdssInPool().size() == 0 not mean that u have not any host in pool it is means that there are no host in pool with status Up. Also no connection between spm and connection to storage pool. In order to choose host as spm it should be in status Up. If host will return getCaps it will be in status up. We are monitoring all vdsms that in status NonOperational "regarding the deadlock issue - i haven't added any lock, that two locks that are performed are unchanged and are present from before this patch - so I don't see how this may cause to a deadlock if the two locks are already present." - U have not add a new lock u just insert reconstruct inside a section under lock. Now make a simple calculation how many locks u need to acquire during run of the flow. "regarding performance - if we don't reconstruct the host will be useless as it cannot connect to the pool and will fail spm selection, so i think that it better to wait another 3 minutes other than lose to option to use the pool." - First of all because of deadlock we will wait forever. Init of 5 hosts, first failed even with reconstruct, the second will failed , 3 will failed. The simple question how much time will wait the last one? -- To view, visit http://gerrit.ovirt.org/7061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec43f368370da88f81dbe211331649a16c53f053 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
