Shahar Havivi has posted comments on this change. Change subject: RFE: Add Granular permissions for VM operations ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/35206/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 15: RebootVm(6, ActionGroup.REBOOT_VM, QuotaDependency.NONE), Line 16: StopVm(7, ActionGroup.STOP_VM, QuotaDependency.BOTH), Line 17: ShutdownVm(8, ActionGroup.SHUT_DOWN_VM, QuotaDependency.VDS_GROUP), Line 18: ChangeDisk(9, ActionGroup.CHANGE_VM_CD, QuotaDependency.NONE), Line 19: //TODO: what about pausevm??? > user currently cannot pause vm, only run and pause so no permission is inte Done Line 20: PauseVm(10, QuotaDependency.NONE), Line 21: HibernateVm(11, ActionGroup.HIBERNATE_VM, QuotaDependency.NONE), Line 22: RunVm(12, ActionGroup.RUN_VM, QuotaDependency.VDS_GROUP), Line 23: RunVmOnce(13, ActionGroup.RUN_VM, QuotaDependency.BOTH), http://gerrit.ovirt.org/#/c/35206/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java: Line 10: DELETE_VM(2, RoleType.USER, true, ApplicationMode.VirtOnly), Line 11: EDIT_VM_PROPERTIES(3, RoleType.USER, true, ApplicationMode.VirtOnly), Line 12: REBOOT_VM(17, RoleType.USER, true, ApplicationMode.VirtOnly), Line 13: STOP_VM(18, RoleType.USER, true, ApplicationMode.VirtOnly), Line 14: SHUT_DOWN_VM(19, RoleType.USER, true, ApplicationMode.VirtOnly), > hm...hard to say. Maybe it does - shutdown is clean vs stop is a forcefull yes there is always the case when admin want to allow pool users only to gracefully shutdown not to cause problem in the guest os... Line 15: PAUSE_VM(20, RoleType.USER, true, ApplicationMode.VirtOnly), Line 16: HIBERNATE_VM(21, RoleType.USER, true, ApplicationMode.VirtOnly), Line 17: RUN_VM(22, RoleType.USER, true, ApplicationMode.VirtOnly), Line 18: CHANGE_VM_CD(5, RoleType.USER, true, ApplicationMode.VirtOnly), http://gerrit.ovirt.org/#/c/35206/4/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java: Line 24: EDIT_VM_PROPERTIES, Line 25: REBOOT_VM, Line 26: STOP_VM, Line 27: SHUT_DOWN_VM, Line 28: PAUSE_VM, > not needed Done Line 29: HIBERNATE_VM, Line 30: RUN_VM, Line 31: CHANGE_VM_CD, Line 32: MIGRATE_VM, -- To view, visit http://gerrit.ovirt.org/35206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ae2d6ad2ebc6c8e0948abe1c413362f4e3dbda7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
