Omer Frenkel has posted comments on this change. Change subject: RFE: Add Granular permissions for VM operations ......................................................................
Patch Set 5: Code-Review+1 (2 comments) minor comment in UI files, but basically +1 for backend, added Tomas... http://gerrit.ovirt.org/#/c/35206/5/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java: Line 139: String ActionGroup___STOP_VM(); Line 140: Line 141: String ActionGroup___SHUT_DOWN_VM(); Line 142: Line 143: String ActionGroup___PAUSE_VM(); left overs of pause Line 144: Line 145: String ActionGroup___HIBERNATE_VM(); Line 146: Line 147: String ActionGroup___RUN_VM(); http://gerrit.ovirt.org/#/c/35206/5/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties File frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties: Line 64: ActionGroup___CONFIGURE_VM_STORAGE=Edit Storage Line 65: ActionGroup___REBOOT_VM=Reebot VM Line 66: ActionGroup___STOP_VM=Stop VM Line 67: ActionGroup___SHUT_DOWN_VM=Shut Down VM Line 68: ActionGroup___PAUSE_VM=Pause VM also here Line 69: ActionGroup___HIBERNATE_VM=Hibernate VM Line 70: ActionGroup___RUN_VM=Run VM Line 71: ActionGroup___CHANGE_VM_CD=Change CD Line 72: ActionGroup___CONNECT_TO_VM=Remote Log In -- To view, visit http://gerrit.ovirt.org/35206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ae2d6ad2ebc6c8e0948abe1c413362f4e3dbda7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
