Alon Bar-Lev has posted comments on this change. Change subject: core : Persist engine session on login and delete on logout ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35361/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java: Line 126: SessionDataContainer.getInstance().setAuthn(engineSessionId, profile.getAuthn()); Line 127: SessionDataContainer.getInstance().setAuthRecord(engineSessionId, authRecord); Line 128: SessionDataContainer.getInstance().setPrincipal(engineSessionId, authRecord.<String>get(Authn.AuthRecord.PRINCIPAL)); Line 129: SessionDataContainer.getInstance().setPrincipalRecord(engineSessionId, principalRecord); Line 130: SessionDataContainer.getInstance().persistEngineSession(engineSessionId); I don't like we do this explicitly... it should be property of the data container at each relevant change or once when session is created or user is assigned. Line 131: Line 132: // Add the user password to the session, as it will be needed later Line 133: // when trying to log on to virtual machines: Line 134: if (getParameters().getPassword() != null) { http://gerrit.ovirt.org/#/c/35361/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java: Line 117: Line 118: return systemRoles; Line 119: } Line 120: Line 121: public EngineSession getEngineSession(String sessionId) { shouldn't this be private? Line 122: return getDbFacade().getEngineSessionDao().getBySessionId(sessionId); Line 123: } Line 124: Line 125: public void cleanupAllEngineSessions() { -- To view, visit http://gerrit.ovirt.org/35361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id716d9c6f65898ccd0ffd84d8b05926b78ac9692 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
