Alon Bar-Lev has posted comments on this change. Change subject: core : Persist engine session on login and delete on logout ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/35361/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java: Line 103: engineSession.setUserId(user.getId()); Line 104: engineSession.setUserName(user.getLoginName()); Line 105: engineSession.setGroupIds(user.getGroupIds()); Line 106: engineSession.setRoleIds(getSystemRolesForUser(user.getId(), user.isAdmin() ? false : true)); Line 107: getDbFacade().getEngineSessionDao().save(engineSession); where do we get the primary key? Line 108: } Line 109: } Line 110: Line 111: private List<Guid> getSystemRolesForUser(Guid userId, boolean isFiltered) { Line 110: Line 111: private List<Guid> getSystemRolesForUser(Guid userId, boolean isFiltered) { Line 112: List<Guid> systemRoles = new ArrayList<>(); Line 113: if (getDbFacade() == null) { Line 114: System.out.println("DbFacade is null"); log? Line 115: } Line 116: if (getDbFacade().getPermissionDao() == null) { Line 117: System.out.println("Permissions dao is null"); Line 118: } Line 113: if (getDbFacade() == null) { Line 114: System.out.println("DbFacade is null"); Line 115: } Line 116: if (getDbFacade().getPermissionDao() == null) { Line 117: System.out.println("Permissions dao is null"); log? Line 118: } Line 119: for (Permissions p : Line 120: getDbFacade().getPermissionDao().getAllForEntity(Guid.SYSTEM, userId, isFiltered)) { Line 121: systemRoles.add(p.getrole_id()); -- To view, visit http://gerrit.ovirt.org/35361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id716d9c6f65898ccd0ffd84d8b05926b78ac9692 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
