Alon Bar-Lev has posted comments on this change. Change subject: core : Modify MLA to use engine session info ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35362/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 843: } Line 844: Line 845: PermissionDAO dao = getDbFacade().getPermissionDao(); Line 846: Line 847: List<Permissions> vmPermissions = dao.getAllForEntity(getVmId(), getCurrentUser().getId(), getSessionId(), false); why do we need the getCurrentUser().getId() if we have the session? Line 848: Line 849: for (Permissions vmPermission : vmPermissions) { Line 850: permissionsToAdd.addPermission(vmPermission.getad_element_id(), vmPermission.getrole_id(), Line 851: getParameters().getVmTemplateId(), VdcObjectType.VmTemplate); -- To view, visit http://gerrit.ovirt.org/35362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f3853166fe635941e65ea2461f7ecda20f4a2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
