Eli Mesika has posted comments on this change.

Change subject: core : Modify MLA to use engine session info
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/35362/1/packaging/dbscripts/upgrade/03_06_0570_add_engine_session_user_flat_groups.sql
File 
packaging/dbscripts/upgrade/03_06_0570_add_engine_session_user_flat_groups.sql:

Line 1: -- Flatten all the objects a user can get permissions on them
s/them//
Line 2: CREATE OR REPLACE VIEW engine_session_user_flat_groups
Line 3: AS
Line 4: SELECT id AS id, user_id AS user_id, 
fnSplitterUuid(engine_sessions.group_ids) AS granted_id
Line 5: FROM   engine_sessions


Line 1: -- Flatten all the objects a user can get permissions on them
Line 2: CREATE OR REPLACE VIEW engine_session_user_flat_groups
A view should be created in the create_views.sql script
Line 3: AS
Line 4: SELECT id AS id, user_id AS user_id, 
fnSplitterUuid(engine_sessions.group_ids) AS granted_id
Line 5: FROM   engine_sessions
Line 6: UNION ALL


Line 10: -- user is also member of 'Everyone'
Line 11: SELECT id, user_id, 'EEE00000-0000-0000-0000-123456789EEE'
Line 12: FROM   engine_sessions;
Line 13: 
Line 14: CREATE OR REPLACE FUNCTION getSessionUserAndGroupsById(v_user_id UUID, 
v_id INTEGER)
and this should be in the user_sp.sql
Line 15: RETURNS SETOF idUuidType STABLE
Line 16:    AS $function$
Line 17: BEGIN
Line 18:    RETURN QUERY


-- 
To view, visit http://gerrit.ovirt.org/35362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f3853166fe635941e65ea2461f7ecda20f4a2a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to