Alon Bar-Lev has posted comments on this change. Change subject: core : Modify MLA to use engine session info ......................................................................
Patch Set 6: (3 comments) http://gerrit.ovirt.org/#/c/35362/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java: Line 184: return user.getId(); Line 185: } Line 186: Line 187: protected long getEngineSessionSeqId() { Line 188: return SessionDataContainer.getInstance().getEngineSessionSeqId(engineContext.getSessionId()); don't you want to check if session id is null here as well? Line 189: } Line 190: Line 191: protected DbFacade getDbFacade() { Line 192: return DbFacade.getInstance(); http://gerrit.ovirt.org/#/c/35362/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java: Line 103: sessionInfo.contentOfSession.put(ENGINE_SESSION_SEQ_ID, getDbFacade().getEngineSessionDao().save(engineSession)); Line 104: } Line 105: } Line 106: Line 107: public long getEngineSessionSeqId(String sessionId) { rename at previous patch to reduce diff? Line 108: return sessionInfoMap.containsKey(sessionId) ? Line 109: (Long) sessionInfoMap.get(sessionId).contentOfSession.get(ENGINE_SESSION_SEQ_ID) : Line 110: -1; Line 111: } http://gerrit.ovirt.org/#/c/35362/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java: Line 65: } Line 66: Line 67: @Override Line 68: public List<Permissions> getAllForAdElement(Guid id) { Line 69: return getAllForAdElement(id, -1, false); where is the -1 magic applied? I could not find it, is it something within sql? Line 70: } Line 71: Line 72: @Override Line 73: public List<Permissions> getAllForAdElement(Guid id, long engineSessionSeqId, boolean isFiltered) { -- To view, visit http://gerrit.ovirt.org/35362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f3853166fe635941e65ea2461f7ecda20f4a2a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
