Alon Bar-Lev has posted comments on this change. Change subject: core : Modify MLA to use engine session info ......................................................................
Patch Set 4: (2 comments) starting to understand this as well... http://gerrit.ovirt.org/#/c/35362/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2313: String sessionId = getParameters().getSessionId(); Line 2314: if (sessionId == null && getContext() != null && getContext().getEngineContext() != null) { Line 2315: sessionId = getContext().getEngineContext().getSessionId(); Line 2316: } Line 2317: return SessionDataContainer.getInstance().getSessionId(sessionId); . sessionId = getParameters().getSessionId(); if (sessionId == null && getContext() != null) { sessionId = getContext().getEngineContext().getSessionId(); } if (sessionId == null) { throw? } return SessionDataContainer.getInstance().getSessionId(sessionId); Line 2318: } http://gerrit.ovirt.org/#/c/35362/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java: Line 183: } Line 184: return user.getId(); Line 185: } Line 186: Line 187: protected long getEngineSessionId() { rename to constant name.. with key dao or whatever to distinct from the session id. Line 188: return SessionDataContainer.getInstance().getSessionId(engineContext.getSessionId()); Line 189: } Line 190: Line 191: protected DbFacade getDbFacade() { -- To view, visit http://gerrit.ovirt.org/35362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f3853166fe635941e65ea2461f7ecda20f4a2a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
