Moti Asayag has posted comments on this change. Change subject: engine: Adding Manipulate provider action group ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35494/1//COMMIT_MSG Commit Message: Line 9: pprovider s/pprovider/provider http://gerrit.ovirt.org/#/c/35494/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java: Line 71: Line 72: @Override Line 73: public List<PermissionSubject> getPermissionCheckSubjects() { Line 74: return Collections.singletonList(new PermissionSubject(Guid.SYSTEM, Line 75: VdcObjectType.System, wouldn't we like to manage the permission per specific user ? meaning adding a provider requires system permissions, but once the provider is created, you should require permissions on the specific provider by a given user. Usually, the system behavior should have look like: 1. Admin (superuser) adds a provider 2. Admin grants permissions on the provider to other user 3. Other user can update/delete that provider do we wish to maintain providers manipulating only by super users and for all of the providers without distinguish ? Line 76: ActionGroup.MANIPULATE_PROVIDERS)); Line 77: } Line 78: Line 79: @Override -- To view, visit http://gerrit.ovirt.org/35494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I360db0b3168331ca0c67335679bfc825461e5091 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
