Eli Mesika has posted comments on this change. Change subject: engine: Adding Manipulate provider action group ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/35494/3/packaging/dbscripts/upgrade/03_06_0580_add_manipulate_provider_role.sql File packaging/dbscripts/upgrade/03_06_0580_add_manipulate_provider_role.sql: Line 16: v_PROVIDER_MANAGER_ROLE_ID := 'DEF00011-0000-0000-0000-DEF000001616'; Line 17: Line 18: INSERT INTO roles_groups (role_id, action_group_id) VALUES (V_SUPER_USER_ID, V_MANIPULATE_PROVIDER_ACTION_GROUP_ID); Line 19: INSERT INTO roles_groups (role_id, action_group_id) VALUES (V_DATA_CENTER_ADMIN_ID, V_MANIPULATE_PROVIDER_ACTION_GROUP_ID); Line 20: INSERT INTO roles(id, name, description, is_readonly, role_type, allows_viewing_children, app_mode) TWS Line 21: SELECT v_PROVIDER_MANAGER_ROLE_ID, 'ProviderManager', 'Provider Manager', true, 1, true, 255 Line 22: WHERE NOT EXISTS ( Line 23: SELECT id FROM roles Line 24: WHERE id = v_PROVIDER_MANAGER_ROLE_ID Line 19: INSERT INTO roles_groups (role_id, action_group_id) VALUES (V_DATA_CENTER_ADMIN_ID, V_MANIPULATE_PROVIDER_ACTION_GROUP_ID); Line 20: INSERT INTO roles(id, name, description, is_readonly, role_type, allows_viewing_children, app_mode) Line 21: SELECT v_PROVIDER_MANAGER_ROLE_ID, 'ProviderManager', 'Provider Manager', true, 1, true, 255 Line 22: WHERE NOT EXISTS ( Line 23: SELECT id FROM roles TWS Line 24: WHERE id = v_PROVIDER_MANAGER_ROLE_ID Line 25: ); Line 26: INSERT INTO roles_groups (role_id, action_group_id) VALUES (v_PROVIDER_MANAGER_ROLE_ID, V_MANIPULATE_PROVIDER_ACTION_GROUP_ID); Line 27: Line 29: have have => has Line 28: Line 29: --As the role for manipulating providers have changed, we must give Line 30: --Permissions to those who are assigned with CREATE_SOTRAGE_POOL_ID Line 31: --to be able to manipulate providers as well Line 32: INSERT INTO permissions (id, role_id, ad_element_id, object_id, object_type_id) TWS Line 33: SELECT uuid_generate_v1(), v_PROVIDER_MANAGER_ROLE_ID, ad_element_id, object_id, object_type_id from permissions Line 34: WHERE role_id IN ( Line 35: SELECT role_id FROM roles_groups where action_group_id = v_CREATE_STORAGE_POOL_ACTION_GROUP_ID Line 36: ); -- To view, visit http://gerrit.ovirt.org/35494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I360db0b3168331ca0c67335679bfc825461e5091 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
