Martin Mucha has posted comments on this change. Change subject: core: do not fail when there's no mac in pool on engine startup. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35392/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java: Line 71 Line 72 Line 73 Line 74 Line 75 > i think that we should notify the user/admin about such cases via an audit DONE. related question: on startup, all MAC specified in DB are "added" to pool. In this case, there will be added as manually added. That's fine. But in this case, each such addition not generates this "pool is empty" empty. So on startup you get N+1 these warnings. I doubt this is OK and acceptable. There are two possible fixes: a) alter call to forceAddMacWithoutLocking so it does not produce AuditLog during startup b) (I'm in favor of this one) since "adding by force" does not respect, whether MAC is in pool or not, or whether it's used or not, it makes no sense to check pool emptiness in this method. So I'd just remove logWhenMacPoolIsEmpty in method forceAddMacWithoutLocking. -- To view, visit http://gerrit.ovirt.org/35392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc486d04748d3a49291746c57955db2aaae2f389 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
