Moti Asayag has posted comments on this change. Change subject: core: do not fail when there's no mac in pool on engine startup. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35392/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java: Line 71 Line 72 Line 73 Line 74 Line 75 > good, that would stop the flood. But should there be flood to be stopped in i don't think there should be a flood on application startup. imo adding a custom mac shouldn't trigger any error for a mac pool, if the mac address doesn't exist in a pool. since ovirt 3.5 is out, i'd try to minimize the changes as possible, and only if they are claimed to be blockers. if an extensive change is required, perhaps it should be discussed in 3.6 context. -- To view, visit http://gerrit.ovirt.org/35392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc486d04748d3a49291746c57955db2aaae2f389 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
