Juan Hernandez has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
Remember to inform and request input in users@ and devel@.
....................................................
File backend/manager/conf/ca/CreateCA.sh
Line 34: openssl ca -selfsign -out ca.pem -in requests/ca.csr \
Line 35: -keyfile private/ca.pem -days 3650 -startdate $4 \
Line 36: -config openssl.conf -extfile cacert.conf \
Line 37: -extensions v3_ca -batch && \
Line 38: openssl x509 -in ca.pem -out certs/ca.der
I almost wrote "Tabs?", but I finally decided not to.
Line 39:
Line 40: exit $?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 865: @DefaultValueAttribute("SignReq.bat")
Line 866: SignScriptName(264),
Line 867:
Line 868: @TypeConverterAttribute(String.class)
Line 869: @DefaultValueAttribute("1")
Can you add a comment here explaining that "1" is the alias required by PKCS#12
key stores and blah, blah, blah?
Line 870: CertAlias(265),
Line 871:
Line 872: @Reloadable
Line 873: @TypeConverterAttribute(String.class)
--
To view, visit http://gerrit.ovirt.org/6883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2abda5778477faff09798a43cf3dc96435efb272
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
