Roy Golan has posted comments on this change. Change subject: core: monitoring - split VDS and VMs monitoring apart ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/27920/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 55: private final VDS _vds; Line 56: Line 57: private boolean processHardwareCapsNeeded; Line 58: private boolean refreshedCapabilities = false; Line 59: VmsMonitoring vmsMonitoring; > please add field modifier (private?) Done Line 60: private static Map<Guid, Long> hostDownTimes = new HashMap<>(); Line 61: private boolean vdsMaintenanceTimeoutOccurred; Line 62: private Map<String, InterfaceStatus> oldInterfaceStatus = new HashMap<String, InterfaceStatus>(); Line 63: Line 470: // get statistics data, images checks and vm_count data (dynamic) Line 471: fetchHostInterfaces(); Line 472: VDSReturnValue statsReturnValue = getResourceManager().runVdsCommand(VDSCommandType.GetStats, Line 473: new VdsIdAndVdsVDSCommandParametersBase(_vds)); Line 474: getResourceManager().getEventListener().updateSchedulingStats(_vds); > please just use getVdsEventListener().update.. Done Line 475: if (!statsReturnValue.getSucceeded() Line 476: && statsReturnValue.getExceptionObject() != null) { Line 477: VDSNetworkException ex = Line 478: (VDSNetworkException) ((statsReturnValue.getExceptionObject() instanceof VDSNetworkException) -- To view, visit http://gerrit.ovirt.org/27920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f4acb9ad6acd07552d4aabe97cd2a63a328b75 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
