Roy Golan has posted comments on this change. Change subject: core: monitoring - split VDS and VMs monitoring apart ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/27920/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 76: import java.util.Map; Line 77: import java.util.Objects; Line 78: import java.util.Set; Line 79: Line 80: public class VmsMonitoring { > Wouldn't VmMonitoring be a better name (matching HostMonitoring)? actually I agree with you. after this whole series is done I'll have a janitoria patch set to cleanup all of this. including constructor and fields ordering and beautifying. to be continued... Line 81: Line 82: private VDS vds; Line 83: private VdsManager vdsManager; Line 84: private final Map<Guid, VM> vmDict; http://gerrit.ovirt.org/#/c/27920/13/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java: Line 130: Line 131: @Override Line 132: protected void auditLog(AuditLogableBase auditLogable, AuditLogType logType) { Line 133: AuditLog al = new AuditLog(); Line 134: al.setlog_type(logType); > Please fix method name: Done Line 135: mockAuditLogDao.save(al); Line 136: } Line 137: Line 138: @Override -- To view, visit http://gerrit.ovirt.org/27920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f4acb9ad6acd07552d4aabe97cd2a63a328b75 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
