Federico Simoncelli has posted comments on this change.
Change subject: core: Add the QEMU guest agent support
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File backend/manager/dbscripts/create_tables.sql
Line 495: migrating_to_vds UUID,
Line 496: app_list VARCHAR(4000),
Line 497: display INTEGER,
Line 498: acpi_enable BOOLEAN,
Line 499: qga_enable BOOLEAN,
I think I need to add a script for an ALTER TABLE (current installations). Is
that correct?
Line 500: session INTEGER,
Line 501: display_ip VARCHAR(255),
Line 502: display_type INTEGER,
Line 503: kvm_enable BOOLEAN,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
Line 450: public VmDynamic() {
Line 451: mExitStatus = VmExitStatus.Normal;
Line 452: mWin2kHackEnable = false;
Line 453: acpi_enable = true;
Line 454: qga_enable = Config.<Boolean>
GetValue(ConfigValues.QEMUGuestAgentEnabled);
I'm not particularly happy with this. I suppose it's the frontend business to
load the the default value and pass it back.
Line 455: kvm_enable = true;
Line 456: session = SessionState.Unknown;
Line 457: boot_sequence = BootSequence.C;
Line 458: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
Line 61: createInfo.add(VdsProperties.kvmEnable,
vm.getkvm_enable().toString()
Line 62: .toLowerCase());
Line 63: createInfo.add(VdsProperties.acpiEnable,
vm.getacpi_enable().toString()
Line 64: .toLowerCase());
Line 65: createInfo.add(VdsProperties.qgaEnable,
vm.getqga_enable().toString()
I was wondering if it's better to check vm.getqga_enable() and add it only when
it's enabled (true). That way we can probably circumvent any possible error
with the vdsm hosts that doesn't have the qgaEnable keyword yet.
Line 66: .toLowerCase());
Line 67:
Line 68: createInfo.add(VdsProperties.Custom,
Line 69:
VmPropertiesUtils.getInstance().getVMProperties(vm.getvds_group_compatibility_version(),
--
To view, visit http://gerrit.ovirt.org/7179
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f6f2d372fd94ae235b1803bcde6ec0f188d488
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
