Federico Simoncelli has posted comments on this change.
Change subject: core: Add the QEMU guest agent support
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File backend/manager/dbscripts/create_tables.sql
Line 475:
Line 476: --
----------------------------------------------------------------------
Line 477: -- Add table "vm_dynamic"
Line 478: --
----------------------------------------------------------------------
Line 479:
This line wasn't changed at all.
Line 480: CREATE TABLE vm_dynamic
Line 481: (
Line 482: vm_guid UUID NOT NULL,
Line 483: status INTEGER NOT NULL,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
Line 86: @Column(name = "acpi_enable")
Line 87: private Boolean acpi_enable;
Line 88:
Line 89: @Column(name = "qga_enable")
Line 90: private Boolean qga_enable;
I don't see any other column using a primitive boolean. I'll change it even
though I'm worried to get into an unknown side-effect.
Line 91:
Line 92: @Column(name = "session")
Line 93: private SessionState session = SessionState.Unknown;
Line 94:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 632: public void setacpi_enable(Boolean value) {
Line 633: this.mVmDynamic.setacpi_enable(value);
Line 634: }
Line 635:
Line 636: public Boolean getqga_enable() {
I suppose I got the idea from getacpi_enable and getkvm_enable (they both use
Boolean).
Line 637: return this.mVmDynamic.getqga_enable();
Line 638: }
Line 639:
Line 640: public void setqga_enable(Boolean value) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1407:
Line 1408: @Reloadable
Line 1409: @TypeConverterAttribute(Boolean.class)
Line 1410: @DefaultValueAttribute("true")
Line 1411: QEMUGuestAgentEnabled(373),
this was discussed on the weekly meeting, we want a global (configurable)
default.
Line 1412:
Line 1413: Invalid(65535);
Line 1414:
Line 1415: private int intValue;
--
To view, visit http://gerrit.ovirt.org/7179
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f6f2d372fd94ae235b1803bcde6ec0f188d488
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
