Michael Kublin has posted comments on this change.
Change subject: [WIP] core: Improved version support (#760546)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 332: }
Line 333: }
Line 334:
Line 335: private static void UpdatePackagesVersions(VDS vds, XmlRpcStruct
xmlRpcStruct) {
Line 336:
Should be consts
Line 337: vds.setversion_name(AssignStringValue(xmlRpcStruct,
"version_name"));
Line 338: vds.setsoftware_version(AssignStringValue(xmlRpcStruct,
"software_version"));
Line 339: vds.setbuild_name(AssignStringValue(xmlRpcStruct,
"build_name"));
Line 340: if (xmlRpcStruct.contains(VdsProperties.host_os)) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 302: markIsSetNonOperationalExecuted();
Line 303: }
Line 304:
Line 305: if (refreshedCapabilities) {
Line 306:
These can be correct, all process of refresh should update dynamic data of vds,
why we need additional update here?
Line 307:
getDbFacade().getVdsDynamicDAO().update(_vds.getDynamicData());
Line 308:
ResourceManager.getInstance().getEventListener().handleVdsVersion(_vds.getId());
Line 309: markIsSetNonOperationalExecuted();
Line 310: }
--
To view, visit http://gerrit.ovirt.org/7186
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alexey Chub <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
