Eli Mesika has posted comments on this change. Change subject: [WIP] core: Improved version support (#760546) ......................................................................
Patch Set 2: (5 inline comments) .................................................... File backend/manager/dbscripts/create_views.sql Line 597: vds_dynamic.vm_migrating as vm_migrating, vds_dynamic.vms_cores_count as vms_cores_count, vds_dynamic.cpu_over_commit_time_stamp as cpu_over_commit_time_stamp, Line 598: vds_dynamic.hypervisor_type as hypervisor_type, vds_dynamic.net_config_dirty as net_config_dirty, vds_groups.high_utilization as high_utilization, vds_groups.low_utilization as low_utilization, Line 599: vds_groups.max_vds_memory_over_commit as max_vds_memory_over_commit, vds_groups.cpu_over_commit_duration_minutes as cpu_over_commit_duration_minutes, Line 600: storage_pool.id as storage_pool_id, storage_pool.name as storage_pool_name, vds_dynamic.reserved_mem as reserved_mem, Line 601: vds_dynamic.guest_overhead as guest_overhead, vds_dynamic.rpm_version as rpm_version, vds_dynamic.software_version as software_version, vds_dynamic.version_name as version_name, vds_dynamic.build_name as build_name, You will probably have to had that for vds_with_tags for search Line 602: vds_dynamic.previous_status as previous_status, vds_statistics.cpu_idle as cpu_idle, vds_statistics.cpu_load as cpu_load, vds_statistics.cpu_sys as cpu_sys, vds_statistics.cpu_user as cpu_user, Line 603: vds_statistics.usage_mem_percent as usage_mem_percent, vds_statistics.usage_cpu_percent as usage_cpu_percent, vds_statistics.usage_network_percent as usage_network_percent, Line 604: vds_statistics.mem_available as mem_available, vds_statistics.mem_shared as mem_shared, vds_statistics.swap_free as swap_free, Line 605: vds_statistics.swap_total as swap_total, vds_statistics.ksm_cpu_percent as ksm_cpu_percent, vds_statistics.ksm_pages as ksm_pages, vds_statistics.ksm_state as ksm_state, .................................................... File backend/manager/dbscripts/vds_sp.sql Line 149: v_vms_cores_count INTEGER , Line 150: v_vm_migrating INTEGER , Line 151: v_reserved_mem INTEGER , Line 152: v_guest_overhead INTEGER , Line 153: v_rpm_version VARCHAR(255), TLS Line 154: v_software_version VARCHAR(40) , Line 155: v_version_name VARCHAR(40) , Line 156: v_build_name VARCHAR(40) , Line 157: v_previous_status INTEGER , Line 203: v_vms_cores_count INTEGER , Line 204: v_vm_migrating INTEGER , Line 205: v_reserved_mem INTEGER , Line 206: v_guest_overhead INTEGER , Line 207: v_rpm_version VARCHAR(255), TLS Line 208: v_software_version VARCHAR(40) , Line 209: v_version_name VARCHAR(40) , Line 210: v_build_name VARCHAR(40) , Line 211: v_previous_status INTEGER , Line 239: if_total_speed = v_if_total_speed,kvm_enabled = v_kvm_enabled, Line 240: mem_commited = v_mem_commited,physical_mem_mb = v_physical_mem_mb, Line 241: status = v_status,vm_active = v_vm_active,vm_count = v_vm_count, Line 242: vm_migrating = v_vm_migrating,reserved_mem = v_reserved_mem, Line 243: guest_overhead = v_guest_overhead,rpm_version = v_rpm_version, software_version = v_software_version, TLS Line 244: version_name = v_version_name,build_name = v_build_name,previous_status = v_previous_status, Line 245: cpu_flags = v_cpu_flags,cpu_over_commit_time_stamp = v_cpu_over_commit_time_stamp, Line 246: hypervisor_type = v_hypervisor_type, Line 247: vms_cores_count = v_vms_cores_count,pending_vcpus_count = v_pending_vcpus_count, .................................................... Commit Message Line 10: Line 11: The following patch provides the following: Line 12: a. Elimination of VdsVersion and usage of RpmVersion instead Line 13: b. Introducing new rpm_version column to vds_dynamic to store VDSM rpm version Line 14: c. Presenation at UI of Vdsm Version Presenation->Presentation Line 15: Line 16: Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e5 Line 17: Signed-off-by: Eli Mesika <[email protected]> Line 18: Signed-off-by: Alexey Chub <[email protected]> -- To view, visit http://gerrit.ovirt.org/7186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alexey Chub <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
