Lior Vernia has posted comments on this change. Change subject: webadmin: Start/stop progress on async operations ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/35964/2/frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java File frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java: Line 132: public void tearDown() throws Exception { Line 133: // Make sure that the query start and end have been called at least once. Line 134: // Some of the tests might call it more than once. Line 135: verify(mockEventBus, atLeastOnce()).fireEvent(new AsyncOperationStartedEvent(mockAsyncQuery.getModel())); Line 136: verify(mockEventBus, atLeastOnce()).fireEvent(new AsyncOperationCompleteEvent(mockAsyncQuery.getModel())); > If you are writing/updating tests for Frontend.java don't forget to also do Done, please take a look - specifically at two of them, I'll mark with a comment. Line 137: verify(queryStartEvent, atLeastOnce()).raise(Frontend.class, EventArgs.EMPTY); Line 138: verify(queryCompleteEvent, atLeastOnce()).raise(Frontend.class, EventArgs.EMPTY); Line 139: Line 140: // Make sure the context is correct http://gerrit.ovirt.org/#/c/35964/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java: Line 145: Line 146: if (asyncOperationCounter == 0) { Line 147: model.startProgress(null); Line 148: } Line 149: ++asyncOperationCounter; > In this case it makes no difference whatsoever, but the prefix ++ and -- is Done Line 150: } Line 151: }); Line 152: addRegisteredHandler(AsyncOperationCompleteEvent.getType(), new AsyncOperationCompleteHandler() { Line 153: @Override -- To view, visit http://gerrit.ovirt.org/35964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24ed80a5453668b37f488e0226f7bdfbf36e503d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
