Alexander Wels has posted comments on this change. Change subject: webadmin: Start/stop progress on async operations ......................................................................
Patch Set 3: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/35964/3/frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java File frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java: Line 161: StatusCodeException exception = new StatusCodeException(0, "0 status code"); //$NON-NLS-1$ Line 162: callbackMultipleActions.getValue().onFailure(exception); Line 163: verify(mockFrontendFailureEvent, never()).raise(eq(Frontend.class), (FrontendFailureEventArgs) any()); Line 164: verify(mockMultipleActionCallback, never()).executed(callbackMultipleParam.capture()); Line 165: verifyAsyncActionStarted(); > This case isn't clear to me - what happens here? Are we okay with a progres This case happens when the user presses escape (closing the dialog). So the progress bar is cleared through that. Line 166: } Line 167: Line 168: /** Line 169: * Run the following test case. Line 344: StatusCodeException exception = new StatusCodeException(0, "0 status code"); //$NON-NLS-1$ Line 345: callbackAction.getValue().onFailure(exception); Line 346: verify(mockFrontendFailureEvent, never()).raise(eq(Frontend.class), (FrontendFailureEventArgs) any()); Line 347: verify(mockActionCallback, never()).executed(any(FrontendActionAsyncResult.class)); Line 348: verifyAsyncActionStarted(); > Same. Same answer. Note the java doc explanation of the test. Basically if someone presses escape somehow it causes an http status code of 0 which in the Frontend code is an ignored failure, so we want to ignore the result. Line 349: } Line 350: Line 351: /** Line 352: * Run the following test case. -- To view, visit http://gerrit.ovirt.org/35964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24ed80a5453668b37f488e0226f7bdfbf36e503d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
