Moti Asayag has posted comments on this change.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
......................................................................
Patch Set 3: (1 inline comment)
General thought: It looks that AddVmInterfaceCommand also supports hotplug and
that HotPlugUnPlugCommand supports not only hotplug, so what is really the
difference between them ?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java
Line 86: VdcBllMessages.VAR__ACTION__ACTIVATE :
VdcBllMessages.VAR__ACTION__DEACTIVATE);
Line 87: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__INTERFACE);
Line 88: }
Line 89:
Line 90: private boolean isVmStatusProperForAttachDetach(VMStatus vmStatus)
{
since this method checks a broader range of statues (vm status applicable for
hotplug + VMStatus.Down) i think it would be proper to reuse
vmStatusDemandsHotPlugNic().
In addition i'd keep same naming convention for both methods (either by
omitting the 'is' from this method's name or adding it to the one below)
Line 91: return vmStatus == VMStatus.Up || vmStatus == VMStatus.Down ||
vmStatus == VMStatus.PoweringUp;
Line 92: }
Line 93:
Line 94: private boolean vmStatusDemandsHotPlugNic(VMStatus vmStatus) {
--
To view, visit http://gerrit.ovirt.org/7176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id759ca8152b455047c9c83447f526aaccdd77d6c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
