Muli Salem has posted comments on this change.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java
Line 86: VdcBllMessages.VAR__ACTION__ACTIVATE :
VdcBllMessages.VAR__ACTION__DEACTIVATE);
Line 87: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__INTERFACE);
Line 88: }
Line 89:
Line 90: private boolean isVmStatusProperForAttachDetach(VMStatus vmStatus)
{
Regarding the first comment - since logically it wouldn't really make sense to
ask if vmStatusDemandsHotPlugNic or VMStatus is down, I prefer to keep them
separate. It improves readability, and allows flexibility.
Regarding the second - done.
Line 91: return vmStatus == VMStatus.Up || vmStatus == VMStatus.Down ||
vmStatus == VMStatus.PoweringUp;
Line 92: }
Line 93:
Line 94: private boolean vmStatusDemandsHotPlugNic(VMStatus vmStatus) {
--
To view, visit http://gerrit.ovirt.org/7176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id759ca8152b455047c9c83447f526aaccdd77d6c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
